Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support mysql-for-test #16

Merged
merged 4 commits into from
Jan 14, 2017
Merged

support mysql-for-test #16

merged 4 commits into from
Jan 14, 2017

Conversation

Chyroc-MD
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.486% when pulling a6f20f7 on Add/mysql-in-docker-for-test into 363146c on master.

jimexist
jimexist reviewed Jan 14, 2017
View reviewed changes
.travis.yml
@@ -12,7 +12,8 @@ node_js:
- "4"

before_install:
- docker run -d -p 12000:12000 jimexist/sqoop:1.99.7-2
- docker run --name mysql-for-test -e MYSQL_ROOT_PASSWORD=12345678 -d mysql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this password used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just use the built-in one https://docs.travis-ci.com/user/database-setup/#MySQL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqoop 的 link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用这个的话，本机和ci就不一致了吧，比如说，我在.travis.yml里面初始化了一些数据库，但是本机不会初始化。如果我手动在本机初始化的话，那么每次在ci上都是一个新的database，但是我本机的可能会有遗留数据，需要我手动清除。

jimexist
jimexist reviewed Jan 14, 2017
View reviewed changes
test/dependencies.sh
@@ -0,0 +1,46 @@
#!/usr/bin/env bash

mysql -uroot -p1234 -e "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact is this is almost only about sql - then you can just write SQL statements here and rename it to test/init.sql

jimexist
jimexist requested changes Jan 14, 2017
View reviewed changes
Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@coveralls
Copy link

coveralls commented Jan 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.486% when pulling a5cf336 on Add/mysql-in-docker-for-test into 363146c on master.

@coveralls
Copy link

coveralls commented Jan 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 86.486% when pulling c9c1ff4 on Add/mysql-in-docker-for-test into 363146c on master.

@Chyroc-MD Chyroc-MD merged commit aded355 into master Jan 14, 2017
@jimexist jimexist deleted the Add/mysql-in-docker-for-test branch January 15, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimexist jimexist jimexist approved these changes

@ZhengHe-MD ZhengHe-MD Awaiting requested review from ZhengHe-MD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chyroc-MD @coveralls @jimexist